codemod-missing-await-act
v0.3.0
Published
Adds missing `await` to `act` calls or methods that contain an `act` call using [jscodeshift](https://github.com/facebook/jscodeshift). The codemod propagates these changes throughout the file. For example, given
Downloads
63
Readme
codemod-missing-await-act
Adds missing await
to act
calls or methods that contain an act
call using jscodeshift.
The codemod propagates these changes throughout the file.
For example, given
import { act } from "react";
function focus(element) {
act(() => {
element.focus();
});
}
test("focusing", () => {
const { container } = render("<button />");
focus(container);
});
will add an await
to act
and also add await
to focus
since focus
is now an async method.
The end result will be
import { act } from "react";
async function focus(element) {
await act(() => {
element.focus();
});
}
test("focusing", async () => {
const { container } = await render("<button />");
await focus(container);
});
Right now we assume that any call to rerender
and unmount
should be awaited.
Getting started
$ npx codemod-missing-await-act ./src
Processing 4 files...
All done.
Results:
0 errors
3 unmodified
0 skipped
1 ok
Time elapsed: 0.428seconds
Usage
$ npx codemod-missing-await-act
codemod-missing-await-act <paths...>
Positionals:
paths [string] [required]
Options:
--version Show version number [boolean]
--help Show help [boolean]
--dry [boolean] [default: false]
--ignore-pattern [string] [default: "**/node_modules/**"]
--import-config A path to a JS file importing all methods whose calls should
be awaited. [string]
--verbose [boolean] [default: false]
Examples:
codemod-missing-await-act ./ Ignores `node_modules` and `build`
--ignore-pattern folders
"**/{node_modules,build}/**"
codemod-missing-await-act ./ Adds await to to all calls of
--import-confg methods imported in that file.
./missing-await-import-config.js
Custom import config
When a newly async function is exported, the codemod will not automatically update all references. However, the codemod summarizes at the end which files are impacted and will generate an import config that can be used to update the remaining references if these are imported via relative imports.
// codemod-missing-await/default-import-config.js
// Import aliases have no effect on the codemod.
// They're only used to not cause JS Syntax errors in this file.
// The codemod will only consider the imported name.
import {
act,
cleanup,
/**
* @includeMemberCalls
* e.g. fireEvent.click()
*/
fireEvent,
render,
renderHook,
} from "@testing-library/react";
import {
act as act2,
cleanup as cleanup2,
/**
* @includeMemberCalls
* e.g. fireEvent.click()
*/
fireEvent as fireEvent2,
render as render2,
renderHook as renderHook2,
} from "@testing-library/react/pure";
import {
act as act3,
cleanup as cleanup3,
/**
* @includeMemberCalls
* e.g. fireEvent.click()
*/
fireEvent as fireEvent3,
render as render3,
renderHook as renderHook3,
} from "@testing-library/react-native";
import {
act as act4,
cleanup as cleanup4,
/**
* @includeMemberCalls
* e.g. fireEvent.click()
*/
fireEvent as fireEvent4,
render as render4,
renderHook as renderHook4,
} from "@testing-library/react-native/pure";
import { unstable_act } from "react";
import { act as ReactTestUtilsAct } from "react-dom/test-utils";
import { act as ReactTestRendererAct } from "react-test-renderer";
For example, when we transform this ~/src/utils.js
file
export function hoverAndClick(element) {
fireEvent.mouseEnter(element);
fireEvent.click(element);
}
hoverAndClick
will now be async.
The codemod generates an import config that will look something like this
import { hoverAndClick as hoverAndClick1 } from "file:///Users/you/repo/src/utils.js";
You can then run the codemod again with the --import-config
option.
The codemod will now also await hoverAndClick
if utils.js
is imported via a relative path.
import { render } from "@testing-library/react";
import { hoverAndClick } from "./utils";
test("hover and click", () => {
const { container } = render("<button />");
hoverAndClick(container);
});
will be transformed into
import { render } from "@testing-library/react";
import { hoverAndClick } from "./utils";
test("hover and click", async () => {
const { container } = await render("<button />");
await hoverAndClick(container);
});
You need to repeat this process until the codemod no longer prompts you at the end to update the import config.
If you use path aliases or modules with newly async exports are imported via package specifiers, you need to manually adjust the import config e.g.
import { hoverAndClick as hoverAndClick1 } from "file:///Users/you/repo/src/utils.js";
import { hoverAndClick as hoverAndClick2 } from "@my/module";
Limitations
Forces call expressions to be awaited
const acting = act(scope);
await anotherPromise;
await acting;
will add await
to the act
call.
This codemod is targetted at act calls.
act()
calls are not allowed to overlap anyway so the original code was already problematic since acting
could also contain an act
call.
async class methods are not propagated
We don't track references to class methods. Only references to (arrow-) function declarations or expressions are tracked.
class MyTestUtils {
render() {
act(scope);
}
}
const utils = new MyTestUtils();
utils.render();
will be transformed to
class MyTestUtils {
async render() {
await act(scope);
}
}
const utils = new MyTestUtils();
// no `await` added
utils.render();
Supported platforms
The following list contains officially supported runtimes. Please file an issue for runtimes that are not included in this list.
- Node.js
18.x || 20.x || 22.x || 23.x